Clarify when Effects are needed for data fetching (#8226)#8238
Open
kanikaa88 wants to merge 1 commit intoreactjs:mainfrom
Open
Clarify when Effects are needed for data fetching (#8226)#8238kanikaa88 wants to merge 1 commit intoreactjs:mainfrom
kanikaa88 wants to merge 1 commit intoreactjs:mainfrom
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
awot-b
reviewed
Mar 3, 2026
|
|
||
| <Note> | ||
|
|
||
| **Note:** The `static getDerivedStateFromProps` method can also be used with components created via the `createClass` API (using the [`create-react-class`](https://www.npmjs.com/package/create-react-class) package). This allows legacy codebases to adopt the newer lifecycle pattern. |
There was a problem hiding this comment.
The mention of legacy create-react-class and getDerivedStateFromProps feels out of scope for modern Hooks-based guidance. To directly address #8226, we should instead focus the example on the core distinction: using an Effect for Initial Sync versus an Event Handler for Pagination. This keeps the mental model clean and relevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the explanation in the "Fetching data" section of "You Might Not Need an Effect" to clarify when an Effect is needed versus when it's not.
The previous text was confusing because it said "You don't need to move this fetch to an event handler" which seemed contradictory given the page's title. This change:
This makes it clearer for readers to understand when Effects are appropriate for data fetching.
Closes #8226